Squiz.Strings.DoubleQuoteUsage not unescaping dollar sign when fixing #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When double quotes are changed to single in content character escaped dolar sign (`\$`) should be replaced to dolar sign (`$`) only.
antograssiot
approved these changes
Jun 4, 2017
jrfnl
approved these changes
Jun 4, 2017
gsherwood
changed the title
\$
|
Thanks a lot for fixing this. |
|
I'm not sure why the status didn't change to |
|
@gsherwood: Would it be possible to get this fix backported to 2.9? I've been helping @jrfnl with the WordPress Core work, I've run into this bug during testing. |
|
@gsherwood Regarding @pento's request - would it help if I created a PR for this for the 2.9 branch ? |
gsherwood
added a commit
that referenced
this pull request
Jul 13, 2017
|
Sorry. I did see this but didn't get around to it. I've backported it now. |
|
@gsherwood Much appreciated! 👍 |
|
Thanks @gsherwood, this works perfectly! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When double quotes are changed to single in content character escaped
dolar sign (
\$) should be replaced to dolar sign ($) only.Let me know if you need separate PR with this fix for v2.