Squiz.WhiteSpace.ScopeKeywordSpacing false positive for static return type

[mathieutu]

Describe the bug
Php8 allows static as a valid return type. I've seen the PHPCS PR which allows that.
However I still have an issue with the Squiz.WhiteSpace.ScopeKeywordSpacing.Incorrect rule.

Code sample

public static function fCreate($attributes = []): static
{
    return static::factory()->create($attributes);
}

Error

 35 | ERROR | [x] Scope keyword "static" must be followed by a single space; found 0 (Squiz.WhiteSpace.ScopeKeywordSpacing.Incorrect)
 43 | ERROR | [x] Scope keyword "static" must be followed by a single space; found newline
    |       |     (Squiz.WhiteSpace.ScopeKeywordSpacing.Incorrect)

Expected behavior
Phpcs should not emit an error for a space after static.
And actually static as a return type should be considerated by phpcs as a Scope Keyword.

Versions:

• OS: MacOS 10.15.7
• PHP: 8
• PHPCS: 3.5.8
• Standard: [PSR2, PSR12]

[jrfnl]

Thanks for reporting this. I can not reproduce the first error. The second one (line 43) I can reproduce with your code sample.

PR #3189 should fix this. Testing appreciated.

[mathieutu]

Thanks for this so fast response!

Indeed, the error line 35 was actually caused by

    public static function myMethod(): static|\Closure

Do you think your fix will cover it too?

EDIT: saw the code you've made for union, so it'll work!

[mathieutu]

@jrfnl I can confirm it's ok, both problems solved!

Thanks for being so efficient!

[jrfnl]

Thanks for testing @mathieutu! Glad to see the confirmation that this will now be fixed once the PR is merged.