Add support for solax x1-hybrid-gen5#131
Closed
GustavoIO wants to merge 1 commit intosquishykid:masterfrom
Closed
Conversation
nazar-pc
reviewed
Jun 20, 2024
| vol.Required("Data"): vol.Schema( | ||
| vol.All( | ||
| [vol.Coerce(float)], | ||
| vol.Length(min=300, max=300), |
Contributor
There was a problem hiding this comment.
Actually I get this on my Hybrid X1 Gen 4 with updated firmware (at least I suspect so, I just contacted support to update firmware and while they didn't reply anything to me, I suspect they have already done it)
Owner
|
This PR seems quite outdated now, I am going to close it for now, but feel free to re-open if you start working on it again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically the schema for gen4 works on gen5 but the api sends more data fields.
Tested on mine.