Project infra #11
Closed
Project infra #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yadij
requested changes
Nov 3, 2023
| Jenkins administrators can at any point force the execution of these jobs | ||
| 1. The code run there is [make-snapshot.sh](https://github.com/kinkie/support-tools/blob/master/squid-ci/make-snapshot.sh). | ||
| The artifacts it generates are replicated to buildmaster and are accessible via https. | ||
| e.g. [master artifacts](https://build.squid-cache.org/job/website-tarballs-head/lastSuccessfulBuild/artifact/artifacts/). |
Contributor
There was a problem hiding this comment.
Suggested change
| e.g. [master artifacts](https://build.squid-cache.org/job/website-tarballs-head/lastSuccessfulBuild/artifact/artifacts/). | |
| e.g. [development version artifacts](https://build.squid-cache.org/job/website-tarballs-head/lastSuccessfulBuild/artifact/artifacts/). |
| 1. The code run there is [make-snapshot.sh](https://github.com/kinkie/support-tools/blob/master/squid-ci/make-snapshot.sh). | ||
| The artifacts it generates are replicated to buildmaster and are accessible via https. | ||
| e.g. [master artifacts](https://build.squid-cache.org/job/website-tarballs-head/lastSuccessfulBuild/artifact/artifacts/). | ||
| 1. A cron job running (mk-release-snapshots.sh) running on on master downloads these artifacts, |
Contributor
There was a problem hiding this comment.
Suggested change
| 1. A cron job running (mk-release-snapshots.sh) running on on master downloads these artifacts, | |
| 1. A cron job running [`mk-release-snapshots.sh`](https://github.com/squid-cache/ci/blob/main/release/mk-release-snapshots.sh) on master downloads these artifacts, |
|
|
||
| 1. Jenkins jobs run at regular cadences, monitoring the repository, run a full build test. | ||
| [trunk-arm64-matrix](https://build.squid-cache.org/job/trunk-arm64-matrix/) is used for master, | ||
| while `6-matrix` and `5-matrix` are (at this time) used for the stable and old releases |
Contributor
There was a problem hiding this comment.
Suggested change
| while `6-matrix` and `5-matrix` are (at this time) used for the stable and old releases | |
| while a version specific `N-matrix` (e.g. `6-matrix` or `5-matrix`) are used for the stable and old releases |
| [trunk-arm64-matrix](https://build.squid-cache.org/job/trunk-arm64-matrix/) is used for master, | ||
| while `6-matrix` and `5-matrix` are (at this time) used for the stable and old releases | ||
| 1. if these jobs are successful, they will trigger the corresponding tarball creation job | ||
| (e.g. [website-tarballs-head](https://build.squid-cache.org/job/website-tarballs-head/) for trunk). |
Contributor
There was a problem hiding this comment.
Suggested change
| (e.g. [website-tarballs-head](https://build.squid-cache.org/job/website-tarballs-head/) for trunk). | |
| (e.g. [`website-tarballs-head`](https://build.squid-cache.org/job/website-tarballs-head/) for the `trunk_amd64_matrix`). |
| while `6-matrix` and `5-matrix` are (at this time) used for the stable and old releases | ||
| 1. if these jobs are successful, they will trigger the corresponding tarball creation job | ||
| (e.g. [website-tarballs-head](https://build.squid-cache.org/job/website-tarballs-head/) for trunk). | ||
| The tarball jobs trust that if they are invoked, it's because the branch is stable. |
Contributor
There was a problem hiding this comment.
"stable" is often misinterpreted as "production ready". Our meaning here is more specific, so lets be clear.
Suggested change
| The tarball jobs trust that if they are invoked, it's because the branch is stable. | |
| The tarball jobs trust that if they are invoked, it's because the branch has a stable build and testing result. |
| As of the 2023-11-02, this is the process to generate snapshot tarballs. | ||
|
|
||
| 1. Jenkins jobs run at regular cadences, monitoring the repository, run a full build test. | ||
| [trunk-arm64-matrix](https://build.squid-cache.org/job/trunk-arm64-matrix/) is used for master, |
Contributor
There was a problem hiding this comment.
Lets be clear this is the VCS branch we use "master" later to mean the server.
Suggested change
| [trunk-arm64-matrix](https://build.squid-cache.org/job/trunk-arm64-matrix/) is used for master, | |
| [`trunk-arm64-matrix`](https://build.squid-cache.org/job/trunk-arm64-matrix/) is used for the VCS ["master" branch](https://github.com/squid-cache/squid/tree/master/), |
| 1. if these jobs are successful, they will trigger the corresponding tarball creation job | ||
| (e.g. [website-tarballs-head](https://build.squid-cache.org/job/website-tarballs-head/) for trunk). | ||
| The tarball jobs trust that if they are invoked, it's because the branch is stable. | ||
| Jenkins administrators can at any point force the execution of these jobs |
Contributor
There was a problem hiding this comment.
punctuation typo.
Suggested change
| Jenkins administrators can at any point force the execution of these jobs | |
| Jenkins administrators can, at any point, force the execution of these jobs. |
| (e.g. [website-tarballs-head](https://build.squid-cache.org/job/website-tarballs-head/) for trunk). | ||
| The tarball jobs trust that if they are invoked, it's because the branch is stable. | ||
| Jenkins administrators can at any point force the execution of these jobs | ||
| 1. The code run there is [make-snapshot.sh](https://github.com/kinkie/support-tools/blob/master/squid-ci/make-snapshot.sh). |
Contributor
There was a problem hiding this comment.
Suggested change
| 1. The code run there is [make-snapshot.sh](https://github.com/kinkie/support-tools/blob/master/squid-ci/make-snapshot.sh). | |
| 1. The code run there is [`make-snapshot.sh`](https://github.com/kinkie/support-tools/blob/master/squid-ci/make-snapshot.sh). |
Contributor
Author
|
For some reason GitHub is preventing me from merging changes or pushing - |
Contributor
Author
|
Closing the PR and creating a new one |
Open
Contributor
Please do not abuse official repositories for PR branches. Use your own repository. We have discussed this before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start adding documentation about the automations supporting the project