Make Request.toCurl work more like Chrome's 'copy as cURL' #9112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - single quotes - URL first - omit the default method Also change binary detection to use isProbablyUtf8 instead, which is promoted to the main okhttp module. Also replace the BinaryMode enum with a boolean to optionally not include the body.
Collaborator
Author
|
Also needs a follow-up to use the body’s content type if it is present. (We prefer the body’s content-type if both are included) |
JakeWharton
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Also change binary detection to use isProbablyUtf8 instead, which is promoted to the main okhttp module.
Also replace the BinaryMode enum with a boolean to optionally not include the body.