Avoid infinite wait on bad response handling. #7954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
approved these changes
Oct 2, 2023
yschimke
added a commit
to yschimke/okhttp
that referenced
this pull request
Oct 15, 2023
…ody is empty. (square#7954) (cherry picked from commit 7308264)
yschimke
added a commit
to yschimke/okhttp
that referenced
this pull request
Oct 15, 2023
…ody is empty. (square#7954) (cherry picked from commit 7308264)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #7938
Avoid hanging on takeHeaders (incorrect 103 handling) when response body is empty.
If we mess up our logic (103 and so on), we call closeInternal on the stream from the timeout, but only if if source.isFinished() is false. For an empty body, this will be true, so the next waitForIo, would wait indefinitely.