Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.x] Cherry pick: fix DoH error when using ip address as hostname #7648

Merged
merged 2 commits into from
Jan 18, 2023
Merged

[4.x] Cherry pick: fix DoH error when using ip address as hostname #7648

merged 2 commits into from
Jan 18, 2023

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke changed the base branch from master to okhttp_4.10.x January 11, 2023 09:18
@yschimke yschimke mentioned this pull request Jan 11, 2023
Merged
@yschimke yschimke marked this pull request as ready for review January 12, 2023 00:58
@yschimke
Copy link
Collaborator Author

@swankjesse ran tests locally, but any idea why this is not running in CI?

https://github.com/square/okhttp/blob/okhttp_4.10.x/.github/workflows/build.yml

@swankjesse swankjesse added the bug Bug in existing code label Jan 14, 2023
@swankjesse
Copy link
Member

I added a label and that kicked it?

Possibly needed one of these to trigger?

  pull_request:
    types: [opened, labeled, unlabeled, synchronize]

@yschimke yschimke merged commit 8eddd1d into square:okhttp_4.10.x Jan 18, 2023
@yschimke yschimke deleted the doh_pick branch February 18, 2023 14:57
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swankjesse swankjesse swankjesse approved these changes

Assignees
No one assigned
Labels
bug Bug in existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yschimke @swankjesse @TaoZang