Ignore early hints for 4.9.x #7196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We’re gonna revamp 1xx handling in 5.0.0. I think we get that working with our new 1xx testing stuff in MockWebServer, then backport to 4.9.x. FYI @yschimke |
yschimke
reviewed
Sep 4, 2022
| @@ -65,7 +65,7 @@ class Http2Reader( | |||
| source = continuation, | |||
| headerTableSizeSetting = 4096 | |||
| ) | |||
|
|
|||
| private const val EARLY_HINTS_CODE = "103" | |||
There was a problem hiding this comment.
This needs to be a ByteString.
Suggested change
| private const val EARLY_HINTS_CODE = "103" | |
| private val EARLY_HINTS_CODE = "103".encodeUtf8() |
|
I don't think the plan is to land this, but it didn't fix the issue, so probably indicates we need to be able to test it to land the eventual fix. |
This was referenced Sep 4, 2022
yschimke
reviewed
Sep 10, 2022
|
Rebased onto 4.10.x and fixed the bug plus adding a test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does the rfc mention if :status: has to be the first response header or not? If it does not, then a for loop to look for the status might be needed.
Alternatively this change can be put in Http2Connection.headers and we can call .get(":status:") on the headers but I think that might end up requiring more changes than it should.