Warn on unused ESLint disable directives in base config
#829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
force-pushed
the
reportUnusedDisableDirectives-config
branch
2 times, most recently
from
9ec0fd8
to
39bc9a0
Compare
bmish
force-pushed
the
reportUnusedDisableDirectives-config
branch
from
39bc9a0
to
798a1a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already suggested this in the README, but we can actually ensure it's enabled for everybody in our shared configs.
Note that it is only possible to warn with this feature (erroring not possible yet, although I've written an RFC regarding this: eslint/rfcs#100).
https://eslint.org/docs/latest/user-guide/configuring/rules#report-unused-eslint-disable-comments