automatically use import/typescript config in base (#705)

square · Jan 12, 2023 · a0111a3 · a0111a3
1 parent 40371bb
commit a0111a3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/config/base.js b/lib/config/base.js
@@ -154,6 +154,7 @@ module.exports = {
     {
       // Tweaks for TypeScript files that we can apply for users even if they don't happen to use our `typescript` config.
       files: ['*.ts'],
+      extends: ['plugin:import/typescript'],
       rules: {
         // Last parameter allows for exporting from a .d.ts file
         'filenames/match-exported': ['error', 'kebab', '\\.d$'],

diff --git a/lib/config/typescript.js b/lib/config/typescript.js
@@ -1,6 +1,8 @@
 'use strict';
 
 // This configuration is intended for use in TypeScript projects.
+// Any TypeScript config we can automatically apply for TypeScript files should be done in the `base` config override instead.
+// @typescript-eslint related config must stay in this separate config as moving it to `base` would require a package.json dependency on typescript.
 
 module.exports = {
   extends: [require.resolve('./base')],
@@ -9,10 +11,7 @@ module.exports = {
   overrides: [
     {
       files: ['*.ts'],
-      extends: [
-        'plugin:@typescript-eslint/recommended',
-        'plugin:import/typescript',
-      ],
+      extends: ['plugin:@typescript-eslint/recommended'],
       rules: {
         // https://github.com/typescript-eslint/typescript-eslint/issues/15#issuecomment-458224762
         'no-useless-constructor': 'off',