fix: Item filters not working and resolve the filter name mismatch #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AustinWu666
changed the title
AustinWu666
force-pushed
the
austinw/BOLT-1006
branch
from
d5c6822
to
00252d5
Compare
kchung
approved these changes
Sep 18, 2024
| {% endif %} | ||
| {% endif %} | ||
| {% endfor %} | ||
|
|
||
| {% set items_options = items_options|merge({ filters: filters }) %} |
There was a problem hiding this comment.
Does item_options = {} need to be defined at line 11?
Seems like we could just do something like
Suggested change
| {% set items_options = items_options|merge({ filters: filters }) %} | |
| {% set items_options = { filters: filters } %} |
There was a problem hiding this comment.
Thanks Kevin, you're right!
|
🎉 This PR is included in version 1.0.0-alpha.14 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
bashunaimiroy
added a commit
that referenced
this pull request
Nov 20, 2024
* alpha: fix: use `seller_preferred_fulfillment` for default fulfillment (#73) feat: use store-info resource (#72) fix: Item filters not working and resolve the filter name mismatch (#70) fix: fix integrity missing cross origin anonymous (#69) build(dependencies): update vulnerable packages (#68) fix: add integrity to cdn scripts and remove unused (#67) chore: add integrity to cdn scripts and remove unused (#66) ci(github-actions): use specific semantic-release version (#63)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
theme agency reported that category, fulfillment, etc filters are not working in brisk
related slack discussion: https://square.slack.com/archives/C04APS9G9RC/p1726591074757099
The reason the item filters are not working is that the filter properties (price_min, price_max) are not being bound to 'filters' during resource loading. Additionally, there's a parsing issue—for example, we use 'status' for in_stock and on_sale, but the front-end SDK sends the parameter as 'item_status,' causing rendering issues.