Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Use Swift Foundation Result type to represent a value and error in ex… #126

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

DJBen
Copy link

@DJBen DJBen commented Jan 28, 2020

…ample project

@sebastianv1
Copy link
Contributor

Love it! Do you mind adding this to the CHANGELOG

@DJBen
Copy link
Author

DJBen commented Jan 29, 2020

Love it! Do you mind adding this to the CHANGELOG

Will do!

@DJBen DJBen force-pushed the sihao/example-project-use-result branch from f9c50b0 to c1a76bd Compare January 30, 2020 03:29

#### Improvements

* Replace demo app's ErrorOptional type with Swift Foundation Result type
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two spaces at the end of this line (creates a newline)

Copy link
Contributor

@sebastianv1 sebastianv1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after minor CHANGELOG edits.

@sebastianv1
Copy link
Contributor

Will merge and cleanup

@sebastianv1 sebastianv1 merged commit 030011f into square:master Jan 31, 2020
@DJBen DJBen deleted the sihao/example-project-use-result branch February 3, 2020 21:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants