Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue #118 #119

Merged
merged 2 commits into from
Apr 16, 2020
Merged

Fixes issue #118 #119

merged 2 commits into from
Apr 16, 2020

Conversation

josegomez
Copy link
Collaborator

Removes the "pretty" icon from the QR Export, but it fixes MacOSX rendering of it.
image

@josegomez josegomez requested a review from alexhauser April 16, 2020 15:42
@josegomez josegomez linked an issue Apr 16, 2020 that may be closed by this pull request
[osx] Replace the QR Generator with one that works better on a Mac #118
Closed
alexhauser
alexhauser approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@alexhauser alexhauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working is better than pretty, so merge away!

@josegomez josegomez merged commit dfd48a8 into master Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexhauser alexhauser alexhauser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[osx] Replace the QR Generator with one that works better on a Mac
2 participants
@josegomez @alexhauser