Skip to content
This repository has been archived by the owner on Nov 2, 2023. It is now read-only.

agent/rule/callback/binding-accessors/sql: unwrap the SQL driver before reading its package path #169

Merged
merged 2 commits into from
Nov 12, 2020
Merged

agent/rule/callback/binding-accessors/sql: unwrap the SQL driver before reading its package path #169

merged 2 commits into from
Nov 12, 2020

Commits on Nov 10, 2020

  1. agent/rule/callback/binding-accessors/sql: unwrap the SQL driver befo… 

    …re reading its package path

Following up on elastic/apm-agent-go#848 and the
addition of the `Unwrap()` method to Elastic's SQL driver tracer, it is now
possible to unwrap it and properly read the package path of the underlying
driver as expected.
    Julio Guerra committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    9ff0c80 View commit details
    Browse the repository at this point in the history

  2. agent/rule/callback/binding-accessors/sql: finer-grained SQL dialect … 

    …method errors

Add finer-grained error keys that can be returned by the SQL dialect getter
method. This also highlighted the fact errors can be assigned multiple keys
while bubbling up the call stack. Therefore, the quick solution to get an error
key is to make `sqerrors.Key()` return the deepest key rather than the top one.
Ideally, it should rather combine multiple keys together in the future.
    Julio Guerra committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    204c448 View commit details
    Browse the repository at this point in the history