Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/add_markdown_to_forms #809

Merged
merged 4 commits into from
Feb 11, 2025
Merged

feature/add_markdown_to_forms #809

merged 4 commits into from
Feb 11, 2025

Conversation

theochr72
Copy link
Contributor

add description_md to form component

lovasoa
lovasoa requested changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@lovasoa lovasoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! looks good to me! we just need to render the markdown, not just display it as text

you can also edit one of the examples in the component's documentation to use description_md instead of description

sqlpage/templates/form.handlebars Outdated Show resolved Hide resolved
Théo Cochereau added 3 commits February 11, 2025 21:57
lovasoa
lovasoa approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@lovasoa lovasoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this contribution !

@lovasoa lovasoa merged commit 3a03b92 into sqlpage:main Feb 11, 2025
10 checks passed
@lovasoa
Copy link
Collaborator

lovasoa commented Feb 11, 2025

image

@lovasoa lovasoa mentioned this pull request Feb 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovasoa lovasoa lovasoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theochr72 @lovasoa