Add support to set the SSL connection option (sqlectron/sqlectron-gui#72

)

spec/servers.spec.js

@@ -21,6 +21,7 @@ describe('servers', () => {
       const newServer = {
         'name': 'My New Mysql Server',
         'client': 'mysql',
+        'ssl': true,
         'host': '10.10.10.15',
         'port': 3306,
         'database': 'authentication',
@@ -43,6 +44,7 @@ describe('servers', () => {
         id,
         'name': 'mysql-vm',
         'client': 'mysql',
+        'ssl': false,
         'host': '10.10.10.10',
         'port': 3306,
         'database': 'mydb',
@@ -65,6 +67,7 @@ describe('servers', () => {
         const newServer = {
           'name': 'My New Mysql Server',
           'client': 'mysql',
+          'ssl': false,
           'host': '10.10.10.15',
           'port': 3306,
           'database': 'authentication',
@@ -87,6 +90,7 @@ describe('servers', () => {
           id,
           'name': 'mysql-vm',
           'client': 'mysql',
+          'ssl': false,
           'host': '10.10.10.10',
           'port': 3306,
           'database': 'mydb',

src/config.js

@@ -15,7 +15,12 @@ export async function prepare() {
   const result = await readJSONFile(filename);
 
   result.servers = result.servers.map(srv => {
+    // ensure all server has an unique id
     if (!srv.id) { srv.id = uuid.v4(); }
+
+    // ensure all servers has the new fileld SSL
+    if (srv.ssl === undefined) { srv.ssl = false; }
+
     return srv;
   });
   await writeJSONFile(filename, result);

src/db/clients/mysql.js

@@ -164,5 +164,14 @@ function _configDatabase(serverInfo, databaseName, localPort) {
     multipleStatements: true,
   };
 
+  if (serverInfo.ssl) {
+    serverInfo.ssl = {
+      // It is not the best recommend way to use SSL with node-mysql
+      // https://github.com/felixge/node-mysql#ssl-options
+      // But this way we have compatibility with all clients.
+      rejectUnauthorized: false,
+    };
+  }
+
   return config;
 }

src/db/clients/postgresql.js

@@ -173,6 +173,7 @@ function _configDatabase(serverInfo, databaseName, localPort) {
   const config = {
     host,
     port,
+    ssl: serverInfo.ssl,
     user: serverInfo.user,
     password: serverInfo.password,
     database: databaseName,

src/db/clients/sqlserver.js

@@ -15,9 +15,10 @@ const _configDatabase = (serverInfo, databaseName) => {
     database: databaseName,
     port,
     options: {
-      encrypt: true,
+      encrypt: serverInfo.ssl,
     },
   };
+
   return config;
 };
 

src/validators/server.js

@@ -69,6 +69,9 @@ const SERVER_SCHEMA = {
     { validator: Valida.Validator.required },
     { validator: clientValidator },
   ],
+  ssl: [
+    { validator: Valida.Validator.required },
+  ],
   host: [
     { sanitizer: Valida.Sanitizer.trim },
     { validator: Valida.Validator.len, min: 1, max: 250 },