Change visibility for inheritance #683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
griffio
force-pushed
the
change-class-visibilty-for-sqldelight-inheritance-use
branch
from
19ca1ff to
018baf9
Compare
JakeWharton
approved these changes
Jun 19, 2025
This is for SqlDelight to allow PostgreSql dialect to have access for indexing element types Fix nameType to INDEX from TABLE - this is likely incorrect
griffio
force-pushed
the
change-class-visibilty-for-sqldelight-inheritance-use
branch
from
018baf9 to
b9f259d
Compare
|
I don't have permission to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
( supports sqldelight/sqldelight#5772 )
This allows SqlDelight PostgreSql dialect to have access for new indexing element types
Please add the class app.cash.sqldelight.dialects.postgresql.grammar.mixins.CreateIndexElementType with external ID sqldelight.null containing stub element type constants to "stubElementTypeHolder" extension.Similar to Sqlite 3.18 dialect uses AlterTableElementType
sql-psi/core/src/main/kotlin/com/alecstrong/sql/psi/core/psi/mixins/AlterTableMixin.kt
Line 131 in 9b2c76d
CHANGELOG.md's "Unreleased" section has been updated, if applicable.