Skip to content

Conversation

@griffio
Copy link
Contributor

@griffio griffio commented May 23, 2025

fixes #sqldelight/sqldelight#5749

Add default values from https://github.com/JetBrains/intellij-community/blob/master/platform/util/resources/misc/registry.properties

Tested with SqlDelight compiler tests - with and without changes to verify that warnings are gone

Changes made to sql-psi can be tested with SqlDelight by adding in settings.gradle

includeBuild('../sql-psi') {
  dependencySubstitution {
    substitute(module("app.cash.sql-psi:core")).using(project(":core"))
    substitute(module("app.cash.sql-psi:environment")).using(project(":environment"))
  }
}

Verify that it actually fixes the output for users when SqlDelight is compiling in a project - The warnings do not appear when doing a clean build using snapshot build

Task :generateMainSampleMigrations
WARN: Attempt to load key 'ide.hide.excluded.files' for not yet loaded registry
WARN: Attempt to load key 'psi.sleep.in.validity.check' for not yet loaded registry
WARN: Attempt to load key 'psi.incremental.reparse.depth.limit' for not yet loaded registry

There does appear to be some other place in this build (unrelated?) that has two of the warnings appear

Task :sample-core:generatecom_alecstrong_sql_psi_sample_core_SampleSqliteParser

WARNING: A terminally deprecated method in sun.misc.Unsafe has been called
WARNING: sun.misc.Unsafe::objectFieldOffset has been called by com.intellij.util.containers.Unsafe )
WARNING: Please consider reporting this to the maintainers of class com.intellij.util.containers.Unsafe
WARNING: sun.misc.Unsafe::objectFieldOffset will be removed in a future release

WARN: Attempt to load key 'psi.sleep.in.validity.check' for not yet loaded registry
WARN: Attempt to load key 'psi.incremental.reparse.depth.limit' for not yet loaded registry

  • CHANGELOG.md's "Unreleased" section has been updated, if applicable.

@griffio griffio marked this pull request as ready for review May 23, 2025 13:44
@AlecKazakova AlecKazakova merged commit fa19ee2 into sqldelight:master May 26, 2025
1 check passed
@griffio griffio deleted the fix-unwanted-environment-log-warnings branch May 26, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants