feat: Abort compiler when rpc fails as unauthenticated #2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleconroy
reviewed
Oct 19, 2023
internal/compiler/compile.go
Outdated
Comment on lines
94
to
96
| if errors.Is(err, rpc.ErrUnauthenticated) { | ||
| break fileLoop | ||
| } |
There was a problem hiding this comment.
I think we can just return early here return nil, merr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the approach of adding an exported error from the
rpcpackage to describe what happened, rather than adding an error likeErrAbortwhich describes an expected outcome.