Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mysql): Add, drop, rename and change enum values #2853

Merged
merged 5 commits into from
Oct 13, 2023

Conversation

kyleconroy
Copy link
Collaborator

Extends the work done in #2680 to support adding and dropping columns and tables.

Fixes #2475

@@ -7,12 +7,12 @@ package com.example.ondeck.mysql
import java.sql.Timestamp
import java.time.Instant

enum class VenuesStatus(val value: String) {
enum class VenueStatus(val value: String) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name changed because the table is called venue not venues. The changed name wasn't taken into account before.

@@ -11,46 +11,46 @@ import (
"time"
)

type VenuesStatus string
type VenueStatus string
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name changed because the table is called venue not venues. The changed name wasn't taken into account before.

@kyleconroy kyleconroy merged commit 39576d6 into main Oct 13, 2023
8 checks passed
@kyleconroy kyleconroy deleted the kyle/mysql-enum-fixes branch October 13, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unnecessary enum type generated for actual schema
1 participant