fix(codegen/golang): Refactor imports code to match templates #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 8, 2023
positiveblue
added a commit
to positiveblue/lnd
that referenced
this pull request
Sep 25, 2023
sqlc has now an official dockerhub organization (sqlc). The old org was the personal dev account, and new images are not uploaded there anymore. It looks like they formed a company (Riza, Inc) and are dedicating 100% of their time to the project (which is great news!) [sqlc v1.21.0](sqlc-dev/sqlc#2709) has a bug generating unvalid go code (files with unused imports) so we use v1.20.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2707
I took a bigger approach than #2708 to fix this issue. The problem was that the
Fieldsmethod didn't use the same logic as thePairmethod. When a template only calledPairbut the import code calledFields, we'd get a mismatch.To fix this, I created a new method called
Pairsthat uses the same logic as the Pair method. I updated the import code to call this. It also checks if the Arg is a struct and checks the fields.This code is really brittle and until we do a large refactoring, we will sadly still run into issues.