Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(engine/dolphin): support CALL statement #2614

Merged
merged 5 commits into from
Aug 29, 2023
Merged

feat(engine/dolphin): support CALL statement #2614

merged 5 commits into from
Aug 29, 2023
+210 −11

Conversation

orisano
Copy link
Contributor

@orisano orisano commented Aug 14, 2023 •
edited
Loading

close #2612

Added CREATE PROCEDURE support for CALL Statement.
And I have updated tidb/parser to support CREATE PROCEDURE.

@andrewmbenton
Copy link
Collaborator

Thanks! The example from this MySQL docs page may be good enough?

@orisano
Copy link
Contributor Author

orisano commented Aug 15, 2023

I added e2e test

@orisano orisano marked this pull request as ready for review August 15, 2023 20:41
@kyleconroy
Copy link
Collaborator

@orisano could you rebase on main? I merged some other dependency updates which conflicts with your changes. Sorry about that.

@kyleconroy kyleconroy added this to the 1.21.0 milestone Aug 28, 2023
@orisano
Copy link
Contributor Author

orisano commented Aug 28, 2023

rebased!

@kyleconroy kyleconroy merged commit e73ad79 into sqlc-dev:main Aug 29, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

Add support for CALL statements in MySQL
3 participants
@orisano @andrewmbenton @kyleconroy