Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify option package support #2513

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Conversation

johanbrandhorst
Copy link
Contributor

The emit_pointers_for_null_types option supports both pgx/v4 and pgx/v5 according to the tests:

https://github.com/kyleconroy/sqlc/tree/main/internal/endtoend/testdata/emit_pointers_for_null_types

Ensure that this is clear in the documentation.

The emit_pointers_for_null_types option supports both pgx/v4
and pgx/v5 according to the tests:

https://github.com/kyleconroy/sqlc/tree/main/internal/endtoend/testdata/emit_pointers_for_null_types

Ensure that this is clear in the documentation.
Copy link
Collaborator

@kyleconroy kyleconroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The original feature predated pgx/v5 I believe.

@kyleconroy kyleconroy merged commit 6281395 into sqlc-dev:main Jul 24, 2023
@johanbrandhorst johanbrandhorst deleted the patch-2 branch July 25, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants