Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from CityID to Lat an Lon, expose sunrise and sunset #233

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Switch from CityID to Lat an Lon, expose sunrise and sunset #233

merged 1 commit into from
Apr 2, 2024

Conversation

Sudrien
Copy link

@Sudrien Sudrien commented Jun 16, 2023

#232 mentions settings.gmtOffset should not be seconds, but it sure looks like it's seconds in the examples.

It also mentions OpenWeatherMap API changes. This

  • updates the API call (less concat, more replace)
  • exposes settings.lat, settings.lon, settings.sunrise, settings.sunset for more options
  • updates the samples

Sudrien pushed a commit to Sudrien/watchy_orbital that referenced this pull request Jun 16, 2023
https://github.com/sqfmi/Watchy/pull/233
25b1913
@Sudrien Sudrien mentioned this pull request Jun 18, 2023
Open
@sqfmi sqfmi merged commit 99cacd2 into sqfmi:dev Apr 2, 2024
@sqfmi
Copy link
Owner

sqfmi commented Apr 2, 2024

Awesome, thank you! Modified the function to be compatible with cityID as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sudrien @sqfmi