PR: Make several GUI/qtbot tests more reliable by increasing timeouts and tweaking the methods used #6714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAM-Gerlach
changed the title
ccordoba12
approved these changes
Mar 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've encountered a number of sporadic test failures with
test_get_helpandtest_set_elapsed_timeon the CIs, so I've increased the relevant timeouts. I also went back and made similar changes to timeouts and tweaks to the methods used in a few of my previous tests that were apparently sporadically failing locally on Linux in a similar manner. Finally, I improved the docstrings of the affected functions; and also standardized the headers as I've been doing for the other files I've modified recently.