Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Find/replace - return match counts on unescaped characters #6526

Merged
merged 2 commits into from
Feb 27, 2018
Merged

PR: Find/replace - return match counts on unescaped characters #6526

merged 2 commits into from
Feb 27, 2018

Conversation

csabella
Copy link
Contributor

@csabella csabella commented Feb 26, 2018 •
edited by ccordoba12
Loading

Fixes #5680.

@pep8speaks
Copy link

pep8speaks commented Feb 26, 2018 •
edited
Loading

Hello @csabella! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on February 26, 2018 at 10:59 Hours UTC

@csabella csabella self-assigned this Feb 26, 2018
@csabella csabella changed the base branch from master to 3.x February 26, 2018 11:06
@ccordoba12 ccordoba12 added this to the v3.2.8 milestone Feb 26, 2018
@jitseniesen jitseniesen mentioned this pull request Feb 26, 2018
Closed
ccordoba12
ccordoba12 approved these changes Feb 27, 2018
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @csabella!

@ccordoba12 ccordoba12 merged commit d096560 into spyder-ide:3.x Feb 27, 2018
ccordoba12 added a commit that referenced this pull request Feb 27, 2018
@ccordoba12
Merge from 3.x: PR #6526
ebf1dd4 
Fixes #5680
@csabella csabella deleted the issue5680 branch February 27, 2018 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@csabella csabella

Labels
None yet
Projects
None yet
Milestone
v3.2.8
Development

Successfully merging this pull request may close these issues.
3 participants
@csabella @pep8speaks @ccordoba12