PR: Install and run window manager in Travis to fix focus issues and unskip now-passing tests #6286
Conversation
|
Hello @CAM-Gerlach! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on January 24, 2018 at 17:28 Hours UTC |
CAM-Gerlach
force-pushed
the
travis-window-manager
branch
from
f55ab7d to
bf61226
Compare
CAM-Gerlach
changed the title
CAM-Gerlach
changed the title
|
@ccordoba12 The great news is that after implementing this, testing, and fiddling around a bit, I not only got all three of my previously skipped focus/"realistic" UI tests passing consistently on all builds (but one), but also got However, the one remaining issue is that the Python 3.5 PyQt5 build consistently segfaults every time as soon as the test collection phase begins before any tests are collected, which started as soon as I added the few lines to load the window manager (before unskipping any tests or making any other changes); I can only assume it is no accident that this build is the one with different setup procedures, using |
spyder/widgets/tests/test_editor.py
Outdated
| @@ -120,7 +121,7 @@ def test_find_number_matches(qtbot): | |||
|
|
|||
| def test_move_current_line_up(editor_bot): | |||
| editor_stack, editor, qtbot = editor_bot | |||
|
|
|||
There was a problem hiding this comment.
Please revert all blank space removals you introduced in this file.
There was a problem hiding this comment.
Oops, accidentally left "remove trailing whitespace when saving" on...would be nice to have a toggle somewhere in the UI to make it less of a pain to be going in an out of preferences to keep changing/verifying it. Fortunately, it happened to be the last thing in my undo history so it has easy to revert.
| reason="It times out in our CIs") | ||
| @pytest.mark.skipif(os.environ.get('CI', None) is not None and os.name == 'nt', | ||
| reason="It times out on AppVeyor.") | ||
| @pytest.mark.timeout(timeout=20, method='thread') |
There was a problem hiding this comment.
Please add @pytest.mark.slow
Wow, this is great @CAM-Gerlach! Thanks a lot!
Yep, I fixed that already in PR #6289. So please address my comment, do a rebase to pick up #6289 and then this one will be ready ;-) |
CAM-Gerlach
force-pushed
the
travis-window-manager
branch
from
bf61226 to
ecc3488
Compare
|
@ccordoba12 Thanks! Should be good to go now. |
I've been noticing consistent problems with tests failing on Travis when focus and other GUI elements are involved. Accordingly, in #6132 @ccordoba12 suggested installing a window manager, as that fixed similar issues with CircleCI in #4151 . Therefore, this is a shot at doing the same for Travis, which would hopefully resolve a ton of frustration I'm having with a the tests in a number of recent PRs. First crack at it will just ensure the code runs without error, and then I'll try enabling tests that failed due to focus/etc. issues to see if this fixes it. However, it can be limited to ensure this PR can get merged quickly; the primary objective is to verify this is actually working and fixes at least some of the problems.