PR: Preserve color scheme on kernel restart #6256
Conversation
| self.shellwidget.silent_execute("%colors linux") | ||
| else: | ||
| self.shellwidget.silent_execute("%colors lightbg") | ||
| self.set_console_scheme(self.shellwidget) |
There was a problem hiding this comment.
Please change set_console_scheme to set_color_scheme
There was a problem hiding this comment.
There is already a different method called set_color_scheme. Before submitting the PR, I wasn't sure if I should use it or not because it takes color_scheme as a parameter, which is a value from the plugin (ipythonconsole.py) and not the widget (client.py). It was a more complicated change, so I opted for directly fixing this one issue.
Do you want me to redo it using the existing set_color_scheme?
There was a problem hiding this comment.
Yes, please. I think it'd be easier to understand that way. Thanks!
There was a problem hiding this comment.
OK, will work on it soon.
|
I think this is good, just left a minor comment. |
| # For issue 6235. IPython was changing the setting of | ||
| # %colors on windows by assuming it was using a dark | ||
| # background. This corrects it based on the scheme. | ||
| self.set_color_scheme(sw.syntax_style) |
There was a problem hiding this comment.
I removed sw.reset(clear=True) because it's part of set_color_scheme.
|
@ccordoba12 Good suggestions; it's much cleaner now. |
|
@csabella, now tests for dedicated consoles are failing. |
|
@ccordoba12 Yes, sorry, trying to figure it out. |
|
Yay! I'm green! I also tested as much of that as I could think of to do manually. I hadn't thought of the dedicated console, so that was a good test case. :-) |
Fixes #6235.