PR: Fix Profiler error when run is stopped #6238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @csabella! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on January 17, 2018 at 23:32 Hours UTC |
ccordoba12
approved these changes
Jan 18, 2018
ccordoba12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6220.
This pull request addresses a few aspects of the issue reported.
When the
Stopbutton was clicked when a profile was running, Spyder still attempted to display the profiler results even know there wouldn't have been any. The profiler only writes results when it finishes. The fix is to recognize the button event and display a different text to the user, along with clearing the datatree.The
load_datamethod in theProfilerDataTreeclass assumed that the default results file existed, but if the run had been canceled, then this file doesn't exist. A try/except was added to this to catch file errors. Note that item 1 should prevent this from being called.