Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Add shortcut to Find in Files in Search menu #6141

Merged
merged 2 commits into from
Jan 7, 2018
Merged

PR: Add shortcut to Find in Files in Search menu #6141

merged 2 commits into from
Jan 7, 2018

Conversation

csabella
Copy link
Contributor

@csabella csabella commented Jan 5, 2018 •
edited by ccordoba12
Loading

Fixes #4111.

  • Add shortcut to action item on search menu. The shortcut context avoids an ambiguous shortcut overload message.
  • Changed triggered event so that the 'Find in Files' option would be checked in View -> Panes.

@pep8speaks
Copy link

pep8speaks commented Jan 5, 2018 •
edited
Loading

Hello @csabella! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on January 05, 2018 at 16:31 Hours UTC

@ccordoba12 ccordoba12 added this to the v3.2.7 milestone Jan 5, 2018
@ccordoba12 ccordoba12 modified the milestones: v3.2.7, v3.2.6 Jan 7, 2018
ccordoba12
ccordoba12 approved these changes Jan 7, 2018
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, working as expected. Thanks @csabella!

@ccordoba12 ccordoba12 merged commit 2f81720 into spyder-ide:3.x Jan 7, 2018
ccordoba12 added a commit that referenced this pull request Jan 7, 2018
@ccordoba12
Merge from 3.x: PR #6141
417c18c 
Fixes #4111
@csabella csabella deleted the issue4111 branch January 7, 2018 17:54
@csabella
Copy link
Contributor Author

csabella commented Jan 7, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2.6
Development

Successfully merging this pull request may close these issues.
3 participants
@csabella @pep8speaks @ccordoba12