PR: Allow tab cycling shortcuts to be configurable in Editor #6123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
Jan 4, 2018
| @@ -385,6 +385,16 @@ def keyPressEvent(self, event): | |||
| handled = True | |||
| if not handled: | |||
| QTabWidget.keyPressEvent(self, event) | |||
|
|
|||
| def tab_navigate(self, delta=1): | |||
There was a problem hiding this comment.
@csabella, Ctrl+Tab is handled differently in the Editor, because there we show a dialog to select among the current opened files. So I think you need to revert this change.
There was a problem hiding this comment.
@ccordoba12 It still works correctly in the Editor even with moving this. Without changing preferences, Ctrl+Tab brings up the dialog to select the file in MRU order and Ctrl+PgDown cycles through the files. But, this code allows those keys to be configurable.
There was a problem hiding this comment.
Ok, great! Then this is ready.
ccordoba12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4842.
BacktabtoShift+Tabwas only for 'nt', but problem existed on linux too, so removed the conditional.Tabsclass, so moved it toBaseTabsclass for it to be used in the editor (which creates aBaseTabswidget) without affecting existing code (like in iPython console).