PR: Remove unnecessary flaky from introspection test, minor cleanup #6099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
approved these changes
Jan 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would have lumped this in with another PR as it is so small, but I didn't want it to go out of scope. Basically, I previously added flaky to the introspection test as it was failing, but both locally and on the CIs (when I tested enabling it), it didn't help; it either failed no runs or all of them, and takes an incredibly long among of time (over 30s per run), so I disabled it again and removed the import, as well as some minor cleanup around the lines that I changed. Sorry about that, and no need to rush it out for 3.2.6 if its anywhere near the critical path.