PR: Catch search regexp error while doing replace/find

[timhoffm]

fixes #5386

Perfroming replace_find() and replace_find_selection() with an invalid regexp used to raise an exception. After this patch, they will do nothing and silently return.

[ccordoba12]

Nice! Thanks a lot for this!

@dalthviz, please review @timhoffm's work.

[rlaverde]

Maybe you could generalize the function rexexp_error_msg of #5614 and use in this PR too, something like:

def safe_regex(pattern):
    ....
    return compile_pattern, error 

[pep8speaks]

Hello @timhoffm! Thanks for updating the PR.

• In the file spyder/widgets/tests/test_editor.py, following are the PEP8 issues :

Line 338:1: E302 expected 2 blank lines, found 1

[ccordoba12]

@timhoffm, don't worry about PEP8 issues in our test files. You can safely ignore pep8speaks in that case.

[timhoffm]

@ccordoba12 If you don't want pep8speaks on test files, you could add

pycodestyle:
    exclude: test_*.py

to .pep8speaks.yml

[ccordoba12]

Good to know! Will do that in another PR (I looked how to do it some time ago but didn't find a straight answer).

[dalthviz]

Thanks @timhoffm, nice work I think everything its ok. I also tested locally and everything regarding your changes works as expected 👍

[dalthviz]

About what @rlaverde says (in terms of the generalization of the rexexp_error_msg of #5614) it could be a possibility. Maybe we could merge this one first an decide what to do regarding the rexexp_error_msg in #5614

What do you guys think @rlaverde, @ccordoba12, @timhoffm?

[ccordoba12]

I agree, let's merge this one first. I think there's an error with Pandas that's making our tests to fail, so I'll take a look at that first before merging more work.

[timhoffm]

@rlaverde, @ccordoba12, @dalthviz

I would do one step at a time. Both this PR and #5614 are reasonable solutions in themselves and can be merged as they are.

In a second step, we can then see if a generalization of regexp_error_msg (note: typo is fixed) makes sense. I'm not yet sure about this. In this request, we don't need the message, and in #5614 we don't need the compiled expression.

[ccordoba12]

In this request we don't need the message and in #5614 we don't need the pattern.

@rlaverde?

[rlaverde]

In this request we don't need the message and in #5614 we don't need the pattern

yes, that's true, but in both the try..except is repeated

try:
    re_pattern = re.compile(search_text)
except re.error:
    return

[ccordoba12]

Let's leave a further refactoring for another PR.