PR: Fix history browsing while debugging #5342
Merged
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @impact27, thanks a lot for working in this one! 👍 |
|
Also could you please move this changes to Thanks! :) |
|
@impact27, no need to move this against 3.x. I think you just forgot to change the PR's base when opening it, but I fixed that for you. |
ccordoba12
reviewed
Sep 27, 2017
spyder/widgets/mixins.py
Outdated
| @@ -813,3 +813,7 @@ def find_in_history(self, tocursor, start_idx, backward): | |||
| return entry[len(tocursor):], idx | |||
| else: | |||
| return None, start_idx | |||
|
|
|||
| def reset_search_pos(self): | |||
| """Reset the position from witch to search the history""" | |||
There was a problem hiding this comment.
Please change witch to which
|
@dalthviz, please review that this works for you locally. This problem happened after introducing several commands while debugging (e.g. |
|
@ccordoba12 It works for me locally 👍
Thanks again @impact27 for working on this one! |
|
Great! Thanks @impact27 for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5202
Edit:
Add reference to the issue