-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Trade ipykernel.serialize for cloudpickle and remove use of publish_data #5341
Conversation
Hello @minrk! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on November 29, 2017 at 17:51 Hours UTC |
@minrk, thanks a lot for taking the time to help us improve our architecture! You know better than anyone else the Jupyter/IPython intricacies, so we really appreciate it. We were thinking to use Any particular advice for using |
No, I don't think there's a big separator between dill and cloudpickle. cloudpickle's just my default choice these days. No objection to switching to dill. |
for easier dispatching without sharing a namespace with user messages
that's 5 files now for every dependency - setup.py, requirements.txt, install.sh, one for each CI
d62ea4f
to
2e053d3
Compare
1ecb282
to
7712057
Compare
… runs in PY2 and the kernel in PY3
Thanks a lot @minrk for this! It's a really great contribution!! I decided it to move it to our stable branch to avoid Spyder to fail when |
Pinging @ghisvail about this one because it adds |
spyder_msg
message type rather than IPython Parallel-specificdata_pub
.This removes the need for special
__spy__
names because it is no longer a shared namespace.cloudpickle
for serializing objects rather than deprecatedipykernel.serialize
that is reserved for IPython Parallel.