PR: Add a safe getcwd function to handle errors when the current working was deleted #5336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @rlaverde! Thanks for updating the PR.
Comment last updated on October 03, 2017 at 17:01 Hours UTC |
|
This needs a rebase now and please also fix the pep8 issues reported above. |
rlaverde
force-pushed
the
getcwd_fallback
branch
from
c24d2ab to
91ca8ce
Compare
…directory is deleted for an external program. - Didn't change it the ipykernel - Didn't change it in the test
rlaverde
force-pushed
the
getcwd_fallback
branch
from
91ca8ce to
4c723b4
Compare
ccordoba12
added a commit
that referenced
this pull request
Oct 4, 2017
Fixes #5099 Conflicts: - spyder/plugins/console.py - spyder/plugins/findinfiles.py - spyder/plugins/projects.py - spyder/plugins/workingdirectory.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5099
I think that returning home directory is better than returning None, because the calls of getcwd expect a directory, and returning None will cause other errors
Maybe a warning should be printed when falling back to home directory
I change it everywhere, except the tests and ipykernel file