Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Don't use super in _handle_error method of IPython console #5162

Merged
merged 1 commit into from
Sep 7, 2017

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Sep 7, 2017

Fixes #5158

I don't know why but using super was failing completely in PyQt4 and now some Windows users report that it also fails in PyQt5.

Overriding completely _handle_error (by taking the code it uses in qtconsole) fixes the issue completely.

@ccordoba12 ccordoba12 added this to the v3.2.3 milestone Sep 7, 2017
@ccordoba12 ccordoba12 merged commit c88de18 into spyder-ide:3.x Sep 7, 2017
@ccordoba12 ccordoba12 deleted the fix-handle-error branch September 7, 2017 21:08
ccordoba12 added a commit that referenced this pull request Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant