Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Increase waiting time and repetitions for tests that enter debugging #5069

Merged
merged 4 commits into from
Aug 26, 2017
Merged

PR: Increase waiting time and repetitions for tests that enter debugging #5069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e460b1
Testing: Increase waiting time for a test because it's failing too much
ccordoba12 Aug 26, 2017
01b0837
Readme: Remove reference to our DMG installers because they are outdated
ccordoba12 Aug 26, 2017
6467920
Testing: Increase waiting time when entering %debug for all tests in …
ccordoba12 Aug 26, 2017
1a135ac
Testing: Increase flaky runs to 10 for all debugging tests
ccordoba12 Aug 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,6 @@ Using one (and only one) of these scientific Python distributions:

### On Mac OSX:

- Using our DMG installer, which can be found
[here](https://github.com/spyder-ide/spyder/releases).
- Using the [Anaconda Distribution](http://continuum.io/downloads).
- Through [MacPorts](http://www.macports.org/).

Expand Down
16 changes: 8 additions & 8 deletions spyder/plugins/tests/test_ipythonconsole.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ def test_get_syspath(ipyconsole, qtbot):
pass


@flaky(max_runs=3)
@flaky(max_runs=10)
@pytest.mark.skipif(os.name == 'nt', reason="It doesn't work on Windows")
def test_browse_history_dbg(ipyconsole, qtbot):
"""Test that browsing command history is working while debugging."""
Expand Down Expand Up @@ -284,7 +284,7 @@ def test_read_stderr(ipyconsole, qtbot):
assert content == client._read_stderr()


@flaky(max_runs=3)
@flaky(max_runs=10)
@pytest.mark.skipif(True, reason="It times out too much (to check later)")
def test_values_dbg(ipyconsole, qtbot):
"""
Expand All @@ -302,7 +302,7 @@ def test_values_dbg(ipyconsole, qtbot):
with qtbot.waitSignal(shell.executed):
shell.execute('1/0')
shell.execute('%debug')
qtbot.wait(500)
qtbot.wait(1000)

# Get value
qtbot.keyClicks(control, '!aa = 10')
Expand All @@ -329,7 +329,7 @@ def test_values_dbg(ipyconsole, qtbot):
assert "*** NameError: name 'aa' is not defined" in control.toPlainText()


@flaky(max_runs=3)
@flaky(max_runs=10)
@pytest.mark.skipif(os.name == 'nt', reason="It doesn't work on Windows")
def test_plot_magic_dbg(ipyconsole, qtbot):
"""Test our plot magic while debugging"""
Expand All @@ -348,7 +348,7 @@ def test_plot_magic_dbg(ipyconsole, qtbot):
with qtbot.waitSignal(shell.executed):
shell.execute('1/0')
shell.execute('%debug')
qtbot.wait(500)
qtbot.wait(1000)

# Test reset magic
qtbot.keyClicks(control, '%plot plt.plot(range(10))')
Expand Down Expand Up @@ -444,11 +444,11 @@ def test_ctrl_c_dbg(ipyconsole, qtbot):
shell.execute('1/0')

shell.execute('%debug')
qtbot.wait(500)
qtbot.wait(1000)

# Test Ctrl+C
qtbot.keyClick(control, Qt.Key_C, modifier=Qt.ControlModifier)
qtbot.wait(500)
qtbot.wait(2000)
assert 'For copying text while debugging, use Ctrl+Shift+C' in control.toPlainText()


Expand All @@ -470,7 +470,7 @@ def test_clear_and_reset_magics_dbg(ipyconsole, qtbot):
shell.execute('1/0')

shell.execute('%debug')
qtbot.wait(500)
qtbot.wait(1000)

# Test clear magic
shell.clear_console()
Expand Down