-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Make value_to_display more robust #5028
Merged
ccordoba12
merged 17 commits into
spyder-ide:3.x
from
ccordoba12:improve-value-to-display
Aug 31, 2017
Merged
PR: Make value_to_display more robust #5028
ccordoba12
merged 17 commits into
spyder-ide:3.x
from
ccordoba12:improve-value-to-display
Aug 31, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @ccordoba12! Thanks for updating the PR.
Comment last updated on August 26, 2017 at 22:15 Hours UTC |
@ccordoba12 could you add a scrrenshot of how it looks? |
- This prevents applying it to instances of them (e.g. collections.defaultdict)
… is greater than 0
ccordoba12
force-pushed
the
improve-value-to-display
branch
3 times, most recently
from
August 26, 2017 22:15
99f56dd
to
e35b19a
Compare
@goanpeca, I updated the description of this PR and added before/after screenshots. @jitseniesen, what do you think about this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4221
This PR
foo object of bar module
(except for know objects, like Dataframes).repr
).value_to_display
recursively to the elements of lists, dicts and tuples. This prevents freezes in the Variable Explorer when people add objects with hugerepr
's as elements of those collection types.Screenshots:
Before
After
TODO:
[skip pep8]