Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Fix setting SPYDER_DEBUG variable on Windows #5008

Merged
merged 2 commits into from
Aug 20, 2017
Merged

PR: Fix setting SPYDER_DEBUG variable on Windows #5008

merged 2 commits into from
Aug 20, 2017

Conversation

dalthviz
Copy link
Member

Fixes #4829

In Windows running something like 3 or True will return 3 however running something like True or 3 will return True. Also running something like False or 3 will return 3. As a reference:

imagen

@dalthviz dalthviz added this to the v3.2.2 milestone Aug 19, 2017
@dalthviz dalthviz self-assigned this Aug 19, 2017
@dalthviz dalthviz requested a review from ccordoba12 August 19, 2017 20:20
@pep8speaks
Copy link

pep8speaks commented Aug 19, 2017 •
edited
Loading

Hello @dalthviz! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on August 19, 2017 at 20:27 Hours UTC

ccordoba12
ccordoba12 approved these changes Aug 20, 2017
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @dalthviz

@ccordoba12 ccordoba12 changed the title PR: Fix SPYDER_DEBUG=3 PR: Fix setting SPYDER_DEBUG variable on Windows Aug 20, 2017
@ccordoba12 ccordoba12 merged commit e750852 into spyder-ide:3.x Aug 20, 2017
ccordoba12 added a commit that referenced this pull request Aug 20, 2017
@ccordoba12
Merge from 3.x: PR #5008
493fe5f 
Fixes #4829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@dalthviz dalthviz

Labels
type:Bug
Projects
None yet
Milestone
v3.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@dalthviz @pep8speaks @ccordoba12