PR: Prevent subprocess.Popen calls to create visible consoles on Windows. #4992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @andfoy! Thanks for updating the PR.
Comment last updated on August 19, 2017 at 22:19 Hours UTC |
ccordoba12
reviewed
Aug 17, 2017
spyder/utils/site/sitecustomize.py
Outdated
| # Prevent subprocess.Popen calls to create visible console windows on Windows. | ||
| # See issue #4932 | ||
| #============================================================================== | ||
|
|
ccordoba12
reviewed
Aug 17, 2017
spyder/utils/site/sitecustomize.py
Outdated
| else: | ||
| creation_flag = 0 # Default value | ||
|
|
||
|
|
ccordoba12
reviewed
Aug 17, 2017
spyder/utils/site/sitecustomize.py
Outdated
| super(SubprocessPopen, self).__init__( | ||
| *args, creationflags=creation_flag, **kwargs) | ||
|
|
||
|
|
|
@andfoy, this is exactly what's needed. Did you test it locally? |
|
@ccordoba12 Yes, I've tested it locally on my Windows VM, and it works as expected! |
|
@andfoy, let's apply this to Windows only. I don't want to touch Linux or macOS with this because they don't have this problem. So please put everything under |
|
@ccordoba12 Actually the error was related to the named argument syntax. |
|
Ok, this looks really good and all our tests are passing. Thanks @andfoy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3529