PR: Show complete exception (not only the traceback) in error QMessageBox. #4711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
Jul 7, 2017
spyder/widgets/sourcecode/base.py
Outdated
| for text in text.splitlines(True): | ||
| if text.startswith(' File') \ | ||
| and not text.startswith(' File "<'): | ||
| is_traceback = True |
There was a problem hiding this comment.
We need to keep this to activate the dialog only when text printed in the internal console is really a traceback. Else the error dialog is shown for things like this
which is no real error, just a warning printed through stderr :-)
|
Please also make that the dialog always Show details, so that people can decide if they are in front of a real error or not. Else, we could be flooded by tons of false positives. |
rlaverde
force-pushed
the
show-exception-qmessagebox
branch
from
fd51273 to
ab20305
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4698