Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Implement dedicated IPython consoles #4691

Merged
merged 15 commits into from
Jul 4, 2017
Merged

PR: Implement dedicated IPython consoles #4691

merged 15 commits into from
Jul 4, 2017

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Jul 3, 2017 •
edited
Loading

Fixes #4418.

This is part of issue #4524.

TODO

  • Close all Matplotlib plots before a new run.

@ccordoba12 ccordoba12 added this to the v3.2 milestone Jul 3, 2017
@ccordoba12 ccordoba12 mentioned this pull request Jul 3, 2017
Closed
10 tasks
@ccordoba12
Run config and preferences: Remove show_kill_warning option
74f06c0 
It was only used in the Python console.
@ccordoba12 ccordoba12 force-pushed the dedicated-ipyconsole branch from b0b0aec to 74f06c0 Compare July 3, 2017 18:05
ccordoba12 added 6 commits July 3, 2017 18:13
@ccordoba12
IPython console: Catch OSError instead of FileNotFoundError because t…
bb16b87 
…he latter doesn't exist in PY2
@ccordoba12
IPython console: Make current_client arg of execute_code optional
62e189a 
This fixes calls to execute_code in other places
@ccordoba12
Main Window: Fix a docstring
205172d
@ccordoba12
Tabs: Add a split_char arg to better select text in IPython console t…
2d1cba5 
…abs when renaming

For those tabs '/' is our split char, and we have to let users know that
they can only alter the text before that char.
@ccordoba12
IPython console: Use split_char when renaming tabs
9f6fb05 
We also forbid '/' to be part of a tab name.
@ccordoba12
Main window: Don't remove TEMPDIR for new instances
9ffefce 
Else new consoles can't be created in other window instances because
they all share the same temp directory.
This was referenced Jul 4, 2017
Closed
Merged
@ccordoba12 ccordoba12 force-pushed the dedicated-ipyconsole branch from def36e9 to 4a409a2 Compare July 4, 2017 15:18
@ccordoba12
Copy link
Member Author

ccordoba12 commented Jul 4, 2017 •
edited
Loading

Let's merge this one to keep things moving. I'll probably need to revisit it in 3.2.1, but it's working reasonably well for now.

@ccordoba12 ccordoba12 merged commit 8dc9163 into spyder-ide:3.x Jul 4, 2017
@ccordoba12 ccordoba12 deleted the dedicated-ipyconsole branch July 4, 2017 20:52
ccordoba12 added a commit that referenced this pull request Jul 4, 2017
@ccordoba12
Merge from 3.x: PR #4691
fe001d5 
Fixes #4418
@larsoner
Copy link
Contributor

Problems during migration (so far):

  1. If there is no console currently open, running a script crashes the IPython kernel, it restarts it but doesn't try to re-run the script. I can't see why the kernel dies because it's restarted immediately (I can only see a flash that it failed). I'll try updating my IPython / Jupyter to try to fix this, but in the meantime it's difficult to debug.

  2. Whenever a script would crash before, I could do import pdb; pdb.pm() to immediately go to the failing code. This now puts me into o stack frame within IPython/core/compilerop.py down to IPython/core/interactiveshell.py (two frames) so I can't get to any variables.

Should I open a new issue to track such migration problems?

@ccordoba12
Copy link
Member Author

@Eric89GXL, yes, please open a new issue for these problems. I don't understand too well you first problem though, so could you post an animated GIF to better describe it? You can do it with a very nice program called Licecap (if you're on Windows or Mac).

@larsoner
Copy link
Contributor

The pdb problem seems to have gone away (maybe with a restart of Spyder?), I'll open new issues as things come up. Thanks @ccordoba12

@ccordoba12
Copy link
Member Author

Great to know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ccordoba12 @larsoner