PR: Add same behaviour for go to previous cell as the one in Matlab #4612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! @rlaverde, please take a look at this one. @liavassif, is this what you want? |
ccordoba12
changed the title
|
@ccordoba12 Yes! |
rlaverde
approved these changes
Jun 15, 2017
| while not self.is_cell_separator(cursor): | ||
| # Moving to the previous code cell | ||
| if self.is_cell_separator(cursor): | ||
| # Move to the previous cell |
There was a problem hiding this comment.
Maybe explain the behavior in the comment, not always will move to the previous cell: "Move to the previous cell or the beginning of the current cell"
There was a problem hiding this comment.
@rlaverde I made the change in the comment below this one, it's ok there or should I make the change here?
There was a problem hiding this comment.
Yes, It's ok, It's even better where you did the change
ccordoba12
approved these changes
Jun 15, 2017
ccordoba12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4611
Preview:
