PR: Add indentation shortcuts and simple indentation for non-Python files #4567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rlaverde, other tests are failing. Please review that. |
rlaverde
force-pushed
the
indentation-shortcuts-and-simple-indentation
branch
from
0bd0904 to
8c4a876
Compare
Fixed, It was missing to forward pass |
ccordoba12
changed the title
ccordoba12
reviewed
Jun 7, 2017
| @@ -367,6 +367,8 @@ | |||
| 'editor/delete line': 'Ctrl+D', | |||
| 'editor/transform to uppercase': 'Ctrl+Shift+U', | |||
| 'editor/transform to lowercase': 'Ctrl+U', | |||
| 'editor/indent': 'Ctrl+[', | |||
| 'editor/unindent': 'Ctrl+]', | |||
There was a problem hiding this comment.
@rlaverde, these shortcuts are used in the reversed, i.e.
Ctrl + ]-> IndentCtrl + [-> Unindent
At least that's the case in Sublime: https://gist.github.com/eteanga/1736542
So please open a new PR to fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3406
Fixes: #4157
I added configurable shortcuts for indent/unindent, with
Ctrl+[/Ctrl+]as defaults, I didn't changeTab/Shift+Tablogic because Tab can't be a shortcut (so I leave it hardcoded), also it could interfere with autocompletionI didn't add new preferences for simple indentation, It's activated in non-Python files. as discussed in #4157