PR: Handle socket creation errors during start up #4522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
May 31, 2017
spyder/app/mainwindow.py
Outdated
| "server to open external files: <br><br> {0} <br><br>" | ||
| "Please, if you are using Windows, try to run as an " | ||
| "administrator from cmd.exe the following command " | ||
| "and restart your computer: <br><br>" |
There was a problem hiding this comment.
Please change this to
An error occurred while creating a socket needed by Spyder. If you are on Windows, please try to run as an Administrator from cmd.exe the following command, and then restart your computer:
ccordoba12
reviewed
May 31, 2017
spyder/app/mainwindow.py
Outdated
| except OSError as e: | ||
| QMessageBox.warning(None, "Spyder", | ||
| _("An error ocurred while creating the socket for the " | ||
| "server to open external files: <br><br> {0} <br><br>" |
There was a problem hiding this comment.
Let's not use the error message here.
ccordoba12
changed the title
ccordoba12
changed the title
ccordoba12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4132