Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Make jedi_patch.py to work with Jedi 0.10.x versions #4341

Merged
merged 1 commit into from
Apr 8, 2017

Conversation

ccordoba12
Copy link
Member

Pinging @ghisvail about this one.

@ccordoba12 ccordoba12 added this to the v3.1.4 milestone Apr 8, 2017
@ccordoba12 ccordoba12 changed the title PR: Make Jedi patch to work with Jedi 0.10.x versions PR: Make jedi_patch.py to work with Jedi 0.10.x versions Apr 8, 2017
@ccordoba12 ccordoba12 merged commit 29ceeca into spyder-ide:3.1.x Apr 8, 2017
@ccordoba12 ccordoba12 deleted the jedi-0.10.x branch April 8, 2017 21:17
@ghisvail
Copy link
Contributor

ghisvail commented Apr 8, 2017

Could you detail a bit more what this PR solves please?

I thought #4121 already fixed Jedi autocompletion...?

Cheers,

@ccordoba12
Copy link
Member Author

ccordoba12 commented Apr 9, 2017

Jedi 0.10.2 was released some days ago and Spyder was not able to work with it because #4121 was only using Jedi 0.10.0.

I thought that was fine because Jedi takes some much time to do new releases. But that was not the case with 0.10.

@ghisvail
Copy link
Contributor

ghisvail commented Apr 9, 2017

Oh I see now. Thanks for heads-up.

ccordoba12 added a commit that referenced this pull request Apr 9, 2017
ccordoba12 added a commit that referenced this pull request Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants