Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Change from pep8 to pycodestyle for style analysis #4218

Merged
merged 8 commits into from
Mar 22, 2017

Conversation

rlaverde
Copy link
Member

@rlaverde rlaverde commented Mar 1, 2017

Fixes #3197


I change only the necessary in the code, I didn't change variables, classes, or config options names.

When checking dependencies, is required 0.6 version of pycodestyle, this is a bit outdated, should we updated it?
PEP8_REQVER = '>=0.6'

@rlaverde rlaverde added this to the v3.2 milestone Mar 1, 2017
@rlaverde rlaverde self-assigned this Mar 1, 2017
@rlaverde rlaverde requested a review from ccordoba12 March 1, 2017 14:39
@ccordoba12
Copy link
Member

When checking dependencies, is required 0.6 version of pycodestyle, this is a bit outdated, should we updated it?

Sure, please update it to a more recent version.

@rlaverde
Copy link
Member Author

rlaverde commented Mar 7, 2017

Sure, please update it to a more recent version.

Done 😄

@ccordoba12
Copy link
Member

ccordoba12 commented Mar 8, 2017

Could you add a test to verify that CodeEditor is showing pep8 warnings? That's something that's not tested at the moment, and given the importance of this change, I think we should start doing it :-)

@ccordoba12 ccordoba12 changed the title PR: Change Pep8 for pycodestyle for code analysis PR: Change pep8 for pycodestyle for code analysis Mar 21, 2017
@ccordoba12 ccordoba12 changed the title PR: Change pep8 for pycodestyle for code analysis PR: Change from pep8 to pycodestyle for code analysis Mar 21, 2017
@ccordoba12
Copy link
Member

test_codeanalysis is now failing @rlaverde, please review that.

…file.

Now it expects 2 blank lines after a function definition.
@rlaverde
Copy link
Member Author

rlaverde commented Mar 22, 2017

The new version of pycodestyle now detects one more style error than the previous version, I updated the num_results

spyder/utils/tests/data/example.py:53:1: E305 expected 2 blank lines after class or function definition, found 1

@ccordoba12
Copy link
Member

Thanks @rlaverde!

@ccordoba12
Copy link
Member

Thanks @rlaverde!

One missing thing: Please update our Readme too.

@ccordoba12 ccordoba12 changed the title PR: Change from pep8 to pycodestyle for code analysis PR: Change from pep8 to pycodestyle for style analysis Mar 22, 2017
@ccordoba12 ccordoba12 merged commit 649ec7e into spyder-ide:3.x Mar 22, 2017
ccordoba12 added a commit that referenced this pull request Mar 22, 2017
@rlaverde rlaverde deleted the pep8-pycodestyle branch March 22, 2017 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants