PR: Add testing requirements to setup.py #4185

rlaverde · 2017-02-22T16:06:00Z

I take the packages that I found in the continuum integration recipes.

I'm not sure if numpy should also be added (pandas will install it as a dependency), and if pillow if needed (circle-ci recipe doesn't install it)

ccordoba12 · 2017-02-22T19:31:12Z

setup.py

@@ -288,8 +288,15 @@ def run(self):
    'numpydoc',
 ]

+extra_require = {


extra_require -> extras_require

The failure in Travis is caused because of this.

ccordoba12 · 2017-02-22T19:32:22Z

setup.py

@@ -288,8 +288,15 @@ def run(self):
    'numpydoc',
 ]

+extra_require = {
+    'test:python_version == "2.7"': ['mock'],


How does this syntax work? I'm just curious and I'd like to understand how it works :-)

I only found that documented in the wheels docs

The idea is that you could run:
pip install spyder[test]
and It will install this extra dependencies

ccordoba12 · 2017-02-22T19:38:14Z

I'm not sure if numpy should also be added (pandas will install it as a dependency), and if pillow if needed (circle-ci recipe doesn't install it)

Ok, no problem about Numpy., i.e. you can remove it.

Pillow is used to generate image representations of arrays in the Variable Explorer. So please add a test for that and leave it as a test dependency ;-)

ccordoba12 · 2017-02-23T15:10:19Z

Ok, good. Now please modify our Travis scripts to install our wheel with [test], then install pyqt5 (i.e. remove our conda install of pyqt5 for pip) and finally run our pytest's there.

The idea is to use our Travis pip slot to test the latest PyQt 5 (which is 5.8 right now) because conda is going to stay at 5.6 for a loong time ;-)

…ng testing dependencies

ccordoba12 · 2017-02-28T17:01:13Z

setup.py

+extras_require = {
+    'test:python_version == "2.7"': ['mock'],
+    'test': ['pytest', 'pytest-qt', 'pytest-cov', 'mock', 'coveralls',
+             'ciocheck', 'flaky', 'pandas', 'scipy', 'sympy', 'pillow'],


ciocheck is not in PiPy. Please remove it.

but it is listed in pipy https://pypi.python.org/pypi/ciocheck/0.1.1

But Travis is complaining about the lack of a package for ciocheck.

In any case, pytest doesn't run ciocheck, so it's not really a test dependency.

ccordoba12 · 2017-02-28T17:03:10Z

continuous_integration/travis/install.sh

@@ -18,6 +18,7 @@ download_code()
    if [ "$PR" != "false" ] ; then
        cd $FULL_SPYDER_CLONE
        git fetch origin pull/$PR/head:travis_pr_$PR
+        git checkout travis_pr_$TRAVIS_PULL_REQUEST


This is done in build_test.sh, so you don't need to do it here:

https://github.com/spyder-ide/spyder/blob/master/continuous_integration/travis/build_test.sh#L10

yes, but if I try to run pip install -e .[test] It'll fail because It was in the master branch

ccordoba12 · 2017-02-28T17:04:05Z

continuous_integration/travis/install.sh

-    # Install extra packages
-    EXTRA_PACKAGES="matplotlib pandas sympy pyzmq pillow"
-    pip install $EXTRA_PACKAGES
+    pip install -e .[test]


This is not needed here. Please do it after the wheel has been built, i.e. here:

https://github.com/spyder-ide/spyder/blob/master/continuous_integration/travis/run_test.sh#L28

ok, this will allow to delete the duplicated checkout

ccordoba12 · 2017-02-28T17:15:38Z

continuous_integration/travis/run_test.sh

@@ -26,6 +26,9 @@ if [ "$USE_CONDA" = true ] ; then
 else
    cd $FULL_SPYDER_CLONE
    pip install dist/spyder-*.whl
+
+    # Install testing packages
+    pip install -e .[test]


Is this line necessary? I mean, what I want is to install our wheel and see if it pulls our test dependencies. So something like

pip install dist/spyder-*.whl[test]

should work (but I'm not sure :-)

I'm not sure neither 🙈

I added a commit to see if this work

It didn't work because dist/spyder-*.whl is a filename

I'll fix this one before merging this PR ;-)

rlaverde · 2017-03-01T13:30:56Z

@ccordoba12 I think the installation using pip is partially working, but I'm blocked because the issue with QtWebEngineWidgets not avalaible in debian/ubuntu

ccordoba12 · 2017-03-07T13:06:49Z

continuous_integration/travis/install.sh

-
-    # Install extra packages
-    EXTRA_PACKAGES="matplotlib pandas sympy pyzmq pillow"
-    pip install $EXTRA_PACKAGES


Please revert this change for now. I have a plan on how to start using the pyqt5 wheels on CircleCI.

I only revert the installation of pyqt (to install it with conda), the other dependencies will be installed by pip install -e .[test]

You're totally right :-)

Also remove coveralls because it's not needed to do testing

ccordoba12 · 2017-03-08T00:57:16Z

@ghisvail, I think this could be useful for you guys if you want to run our tests in the Debian infrastructure.

Fixes: #4174

ghisvail · 2017-03-08T10:32:42Z

Could be, assuming you guys distribute your tests following the pytest guidelines. The Debian packaging is not currently CI tested on the Debian infrastructure.

Another thing which could help would be to verify whether spyder can be tested with pytest-xvfb instead of manual calls to xvfb / xvfb-run. The latter are known to be occasionally unreliable on parallel execution setups in our experience. Same comment applies to qtpy and qtawesome. It worked for spyder-unittest.

ccordoba12 · 2017-03-08T15:01:56Z

assuming you guys distribute your tests following the pytest guidelines

I think we are, by "inlining test directories into [our] application package"

Another thing which could help would be to verify whether spyder can be tested with pytest-xvfb

CircleCi always starts a xvfb instance, so we haven't seen the need of using pytest-xvfb. However, I'm not opposed to idea :-) Could you open a PR to see how that could work?

rlaverde added this to the v3.1.4 milestone Feb 22, 2017

rlaverde self-assigned this Feb 22, 2017

rlaverde requested review from ccordoba12 and goanpeca February 22, 2017 16:06

ccordoba12 reviewed Feb 22, 2017

View reviewed changes

Add testing requirements to setup.py

4403069

rlaverde force-pushed the required-test-packages branch from d11acb9 to 4403069 Compare February 23, 2017 14:36

Test using latest pyqt5 from pip, and use extra_required for installi…

aad1163

…ng testing dependencies

ccordoba12 reviewed Feb 28, 2017

View reviewed changes

rlaverde force-pushed the required-test-packages branch from 25d73a3 to 9c5597e Compare March 1, 2017 12:53

ccordoba12 reviewed Mar 7, 2017

View reviewed changes

rlaverde added 3 commits March 7, 2017 17:56

Remove ciockeck from test dependencies.

ccc69bd

Move dependencpies installation after wheel bulding.

aa9f541

Turn back to install pyqt using conda in Travis.

4c09c75

rlaverde force-pushed the required-test-packages branch from 9c5597e to 4c09c75 Compare March 7, 2017 22:56

ccordoba12 added 3 commits March 7, 2017 19:30

Testing: Fix wheel installation with test dependencies

43b77a8

setup.py: Add missing matplotlib test dependency

fe73692

Also remove coveralls because it's not needed to do testing

Testing: Move a variable to the right place in a Travis script

bbc84e0

ccordoba12 merged commit 8fa3cd4 into spyder-ide:3.1.x Mar 8, 2017

ccordoba12 added a commit that referenced this pull request Mar 8, 2017

Merge from 3.1.x: PR #4185

72ee42e

Fixes: #4174

ccordoba12 added a commit that referenced this pull request Mar 8, 2017

Merge from 3.x: PR #4185

ce78a93

Fixes: #4174

rlaverde deleted the required-test-packages branch March 8, 2017 15:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PR: Add testing requirements to setup.py #4185

PR: Add testing requirements to setup.py #4185

rlaverde commented Feb 22, 2017

ccordoba12 Feb 22, 2017

ccordoba12 Feb 22, 2017

ccordoba12 Feb 22, 2017

rlaverde Feb 23, 2017

ccordoba12 commented Feb 22, 2017

ccordoba12 commented Feb 23, 2017

ccordoba12 Feb 28, 2017

rlaverde Feb 28, 2017

ccordoba12 Feb 28, 2017

ccordoba12 Feb 28, 2017

rlaverde Feb 28, 2017

ccordoba12 Feb 28, 2017 •

edited

Loading

rlaverde Feb 28, 2017

ccordoba12 Feb 28, 2017

rlaverde Feb 28, 2017

rlaverde Mar 1, 2017

ccordoba12 Mar 7, 2017

rlaverde commented Mar 1, 2017

ccordoba12 Mar 7, 2017 •

edited

Loading

rlaverde Mar 7, 2017

ccordoba12 Mar 8, 2017

ccordoba12 commented Mar 8, 2017

ghisvail commented Mar 8, 2017

ccordoba12 commented Mar 8, 2017

PR: Add testing requirements to setup.py #4185

PR: Add testing requirements to setup.py #4185

Conversation

rlaverde commented Feb 22, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ccordoba12 commented Feb 22, 2017

ccordoba12 commented Feb 23, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ccordoba12 Feb 28, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rlaverde commented Mar 1, 2017

ccordoba12 Mar 7, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ccordoba12 commented Mar 8, 2017

ghisvail commented Mar 8, 2017

ccordoba12 commented Mar 8, 2017

ccordoba12 Feb 28, 2017 •

edited

Loading

ccordoba12 Mar 7, 2017 •

edited

Loading