PR: Added Matlab files import tests #4102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking good :-), ping when its done for review |
|
@goanpeca This PR is ready to go! |
|
Yep, our Travis tests are failing because of a new release of Jedi. I'll fix it right away ;-) |
ccordoba12
changed the title
ccordoba12
reviewed
Feb 4, 2017
spyder/utils/tests/test_iofuncs.py
Outdated
| inf, _ = io.load_matlab(path) | ||
| valid = True | ||
| for var in sorted(real_values.keys()): | ||
| valid = valid and np.sum(real_values[var] == inf[var]) |
There was a problem hiding this comment.
Why are you using np.sum here?
ccordoba12
reviewed
Feb 6, 2017
spyder/utils/tests/test_iofuncs.py
Outdated
| import numpy as np | ||
| import spyder.utils.iofuncs as io | ||
|
|
||
| __location__ = os.path.realpath(os.path.join(os.getcwd(), |
There was a problem hiding this comment.
Make this a constant, i.e. LOCATION
ccordoba12
reviewed
Feb 8, 2017
spyder/utils/tests/test_iofuncs.py
Outdated
| @@ -13,13 +13,25 @@ | |||
| import numpy as np | |||
| import spyder.utils.iofuncs as io | |||
|
|
|||
| __location__ = os.path.realpath(os.path.join(os.getcwd(), | |||
| LOCATION = os.path.realpath(os.path.join(os.getcwd(), | |||
| os.path.dirname(__file__))) | |||
There was a problem hiding this comment.
Please align this line correctly to be at the same level of os.getcwd() above.
ccordoba12
reviewed
Feb 8, 2017
spyder/utils/tests/test_iofuncs.py
Outdated
| os.path.dirname(__file__))) | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def real_values(): | ||
| path = os.path.join(__location__, 'numpy_data.npz') | ||
| """ | ||
| Loads a Numpy pickled file. |
ccordoba12
reviewed
Feb 8, 2017
spyder/utils/tests/test_iofuncs.py
Outdated
| over several variable types, such as: Matrices/Vectors, Scalar and | ||
| Complex numbers, Structs, Strings and Cell Arrays. The set of variables | ||
| was defined to allow and test the deep conversion of a compound type, | ||
| i.e., A struct that contains other types that need to be converted, |
ccordoba12
reviewed
Feb 8, 2017
spyder/utils/tests/test_iofuncs.py
Outdated
|
|
||
| This test loads a file stored in MATLAB, the variables defined are | ||
| equivalent to the manually converted values done over Numpy. This test | ||
| allows to evaluate the function which processes the conversion automa |
ccordoba12
added a commit
that referenced
this pull request
Feb 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4076
This test allows to confirm and validate the main datatypes defined in MATLAB, including: